Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update banner for moveit2 - foxy #604

Open
wants to merge 3 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

auman66
Copy link
Contributor

@auman66 auman66 commented Mar 10, 2021

Description

Update the warning banner to point to MoveIt2 Foxy and MoveIt1 Noetic

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@davetcoleman
Copy link
Member

Travis:

ERROR: End tag contains attributes.

<p class="last">This is the ROS Kinetic version of the tutorials, intended for ROS Kinetic users only.<br/>
If you are using a ROS Melodic release, we recommmend the <a class="reference external" href="http://docs.ros.org/melodic/api/moveit_tutorials/html/index.html">Melodic tutorials</a> or the latest <a class="reference external" href="https://ros-planning.github.io/moveit_tutorials/">master branch tutorials</a>.
<p class="first admonition-title">WARNING: Old Tutorial Version</p>
<p class="last">The latest (and last) version of <a class="reference external" href="http://ros-planning.github.io/moveit_tutorials/">MoveIt 1 is for ROS Noetic</a>, which is still actively developed. See also <a class="reference external" href="http://moveit2_tutorials.picknik.ai/">MoveIt 2 tutorials</a> and other available versions in drop down box on left.</p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p class="last">The latest (and last) version of <a class="reference external" href="http://ros-planning.github.io/moveit_tutorials/">MoveIt 1 is for ROS Noetic</a>, which is still actively developed. See also <a class="reference external" href="http://moveit2_tutorials.picknik.ai/">MoveIt 2 tutorials</a> and other available versions in drop down box on left.</p
<p class="last">
The latest (and last) version of <a class="reference external" href="http://ros-planning.github.io/moveit_tutorials/">MoveIt 1 is for ROS Noetic</a>, which is still actively developed.
See also <a class="reference external" href="http://moveit2_tutorials.picknik.ai/">MoveIt 2 tutorials</a> and other available versions in drop down box on left.
</p>

was missing end bracket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants